top and head: allow limit keywords
#4249
Open
+70
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
RyanL1997
approved these changes
Sep 8, 2025
Collaborator
RyanL1997
left a comment
RyanL1997
left a comment
There was a problem hiding this comment.
Thanks for the change, in generally LGTM.
Signed-off-by: Simeon Widdis <[email protected]>
ykmr1224
previously approved these changes
Sep 9, 2025
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
RyanL1997
previously approved these changes
Sep 10, 2025
ykmr1224
previously approved these changes
Sep 11, 2025
noCharger
previously approved these changes
Sep 12, 2025
Collaborator
noCharger
left a comment
noCharger
left a comment
There was a problem hiding this comment.
Please resolve conflict
Swiddis
force-pushed
the
feature/headtop-limit
branch
from
9c80c9f to
824ee95
Compare
ykmr1224
reviewed
Sep 18, 2025
ppl/src/test/java/org/opensearch/sql/ppl/utils/SPathRewriteTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Widdis <[email protected]>
ykmr1224
previously approved these changes
Sep 26, 2025
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Contributor
|
This PR is stalled because it has been open for 2 weeks with no activity. |
Signed-off-by: Simeon Widdis <[email protected]>
Contributor
|
This PR is stalled because it has been open for 2 weeks with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small set of improvements:
limit=Nforheadandtop, similar to whattimechartsupports. Helps makes queries slightly more readable if storing them somewhere.limitto the available keyword field names (wasn't added by timechart).AstPlanningTestto help split upAstBuilderTest, since that class is pretty large/unwieldy.Related Issues
N/A
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.